New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the warning reported in #2440 #2449

Merged
merged 2 commits into from Jun 20, 2017

Conversation

2 participants
@matthid
Member

matthid commented Jun 19, 2017

fix the warning by implementing internal 404 propagation and handling. There is still room for improvement: For example there should be no point in requesting additional urls when one already told you that the package is not available. This might not be true for custom servers on all urls but it must be true for the one nuget.exe is using (otherwise it wouldn't work and the server would be useless/only work with paket).

fixes #2440

matthid added some commits Jun 19, 2017

fix the warning by implementing internal 404 propagation and handling…
…. There is still room for improvement: For example there should be no point in requesting additional urls when one already told you that the package is not available. This might not be true for custom servers on all urls but it must be true for the one nuget.exe is using (otherwise it wouldn't work and the server would be useless/only work with paket).

@forki forki merged commit 7c881ae into master Jun 20, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@matthid matthid deleted the fix_2440_warning branch Jul 26, 2017

@matthid matthid added this to NuGet API & Performance in Breaking Changes Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment