New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account xamarin.*.csharp.targets when finding location … #2460

Merged
merged 1 commit into from Jun 25, 2017

Conversation

Projects
None yet
3 participants
@dmunch
Contributor

dmunch commented Jun 23, 2017

… for inserting framework specific props/targets.

E.g. the following NuGet packages generate target framework specific properties.

framework: monoandroid70

source https://nuget.org/api/v2

nuget Xamarin.Android.Support.v4 == 25.3.1
nuget Xamarin.Android.Support.v7.RecyclerView == 25.3.1
nuget Xamarin.Android.Support.Design == 25.3.1
nuget Xamarin.Android.Support.v7.CardView == 25.3.1
<Choose>
    <When Condition="$(TargetFrameworkIdentifier) == 'MonoAndroid' And ($(TargetFrameworkVersion) == 'v1.0' Or $(TargetFrameworkVersion) == 'v2.2' Or $(TargetFrameworkVersion) == 'v2.3' Or $(TargetFrameworkVersion) == 'v4.0.3' Or $(TargetFrameworkVersion) == 'v4.1' Or $(TargetFrameworkVersion) == 'v4.2' Or $(TargetFrameworkVersion) == 'v4.3' Or $(TargetFrameworkVersion) == 'v4.4' Or $(TargetFrameworkVersion) == 'v4.4W' Or $(TargetFrameworkVersion) == 'v5.0' Or $(TargetFrameworkVersion) == 'v5.1' Or $(TargetFrameworkVersion) == 'v6.0' Or $(TargetFrameworkVersion) == 'v7.0' Or $(TargetFrameworkVersion) == 'v7.1')">
      <PropertyGroup

If not placed after the import of Xamarin.Android.CSharp.targets those properties won't be defined resulting in a broken build.

Not quite sure if or where to add tests for those, any hints appreciated!

When finding location for inserting framework specific props/targets …
…take into account xamarin.*.csharp.targets as well.
@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jun 24, 2017

Member

Is there a more general solution to this problem? I don't think it is good to list the world here...

Member

matthid commented Jun 24, 2017

Is there a more general solution to this problem? I don't think it is good to list the world here...

@forki forki merged commit 422d2ee into fsprojects:master Jun 25, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment