New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments in the references file. #2477

Merged
merged 1 commit into from Jul 1, 2017

Conversation

Projects
None yet
2 participants
@fsoikin
Contributor

fsoikin commented Jun 30, 2017

Fixes #2371.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 1, 2017

Member

Cool!

Member

forki commented Jul 1, 2017

Cool!

@forki forki merged commit 5dc3772 into fsprojects:master Jul 1, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@fsoikin

This comment has been minimized.

Show comment
Hide comment
@fsoikin

fsoikin Jul 2, 2017

Contributor

@forki note that this may become a breaking change under some very specific circumstances: before this, the removeComment function allowed comments to start anywhere, but now comments have to start either at the beginning of the line or after a space.

Also, I have realized that a comment can start after a space, but not after a tab. Do you think it would be a good idea to update it to allow tabs as well? Or perhaps anything that is Char.IsWhitespace?

Contributor

fsoikin commented Jul 2, 2017

@forki note that this may become a breaking change under some very specific circumstances: before this, the removeComment function allowed comments to start anywhere, but now comments have to start either at the beginning of the line or after a space.

Also, I have realized that a comment can start after a space, but not after a tab. Do you think it would be a good idea to update it to allow tabs as well? Or perhaps anything that is Char.IsWhitespace?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 2, 2017

Member

Char.iswhitespace sounds good

Member

forki commented Jul 2, 2017

Char.iswhitespace sounds good

@fsoikin

This comment has been minimized.

Show comment
Hide comment
@fsoikin

fsoikin Jul 2, 2017

Contributor

Got it. #2479

Contributor

fsoikin commented Jul 2, 2017

Got it. #2479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment