New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NugetV2 querying #2472 #2485

Merged
merged 1 commit into from Jul 5, 2017

Conversation

5 participants
@bhugot
Contributor

bhugot commented Jul 5, 2017

Should Fix for #2472

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jul 5, 2017

Member

Oh really? So this url was wrong all this time? Or are there some NuGet servers behaving differently?

Member

matthid commented Jul 5, 2017

Oh really? So this url was wrong all this time? Or are there some NuGet servers behaving differently?

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jul 5, 2017

Member

/cc @forki might know something out of his memories?

I need some time to look at all of this and go through the specs :/. And my todo list is always full.

Member

matthid commented Jul 5, 2017

/cc @forki might know something out of his memories?

I need some time to look at all of this and go through the specs :/. And my todo list is always full.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 5, 2017

Member

against which feed is that?

Member

forki commented Jul 5, 2017

against which feed is that?

@bhugot

This comment has been minimized.

Show comment
Hide comment
@bhugot

bhugot Jul 5, 2017

Contributor

The url was working on nuget.org v2 and v3 but was not on nexus or artifactory. With () it s seems to be working on all

Contributor

bhugot commented Jul 5, 2017

The url was working on nuget.org v2 and v3 but was not on nexus or artifactory. With () it s seems to be working on all

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 5, 2017

Member

@maartenba do you know something about this? and would it work with myget?

Member

forki commented Jul 5, 2017

@maartenba do you know something about this? and would it work with myget?

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jul 5, 2017

Member

anyone knows which one is correct according to the spec?

Member

matthid commented Jul 5, 2017

anyone knows which one is correct according to the spec?

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jul 5, 2017

Member

Maybe there even is a difference between them?

Member

matthid commented Jul 5, 2017

Maybe there even is a difference between them?

@bhugot

This comment has been minimized.

Show comment
Hide comment
@bhugot

bhugot Jul 5, 2017

Contributor

There is no diff if you look at the data I think it's just an implementation of odata

In code we already use

let url = sprintf "%s/Packages(Id='%O',Version='%O')" nugetURL packageName version

And i think some odata implementation accept a call without () but it's the same than with .

Contributor

bhugot commented Jul 5, 2017

There is no diff if you look at the data I think it's just an implementation of odata

In code we already use

let url = sprintf "%s/Packages(Id='%O',Version='%O')" nugetURL packageName version

And i think some odata implementation accept a call without () but it's the same than with .

@Reelix

This comment has been minimized.

Show comment
Hide comment
@Reelix

Reelix Jul 5, 2017

Based off the console output, it's trying to pull (URL and package name changed)

http://myserver.com/nuget/private/Packages?$filter=(tolower(Id)%20eq%20%27company.packageName%27)%20and%20(NormalizedVersion%20eq%20%271.1.423.393%27)

Which throws a 500 error.

For what it's worth,

https://www.myget.org/F/hangfire/api/v2/Packages?$filter=(tolower(Id)%20eq%20%27company.packageName%27)%20and%20(NormalizedVersion%20eq%20%271.1.423.393%27)

With the same parameters does not throw the same error. It seems to be NuGet server specific.

If it helps, we're running

ProGet © 2017 Inedo, LLC - Version 4.0.9 (Build 4)

Reelix commented Jul 5, 2017

Based off the console output, it's trying to pull (URL and package name changed)

http://myserver.com/nuget/private/Packages?$filter=(tolower(Id)%20eq%20%27company.packageName%27)%20and%20(NormalizedVersion%20eq%20%271.1.423.393%27)

Which throws a 500 error.

For what it's worth,

https://www.myget.org/F/hangfire/api/v2/Packages?$filter=(tolower(Id)%20eq%20%27company.packageName%27)%20and%20(NormalizedVersion%20eq%20%271.1.423.393%27)

With the same parameters does not throw the same error. It seems to be NuGet server specific.

If it helps, we're running

ProGet © 2017 Inedo, LLC - Version 4.0.9 (Build 4)

@bhugot

This comment has been minimized.

Show comment
Hide comment
@bhugot

bhugot Jul 5, 2017

Contributor

try with ()

Contributor

bhugot commented Jul 5, 2017

try with ()

@maartenba

This comment has been minimized.

Show comment
Hide comment
@maartenba

maartenba Jul 5, 2017

OData specific imo, ping the respective support alias for the servers that are throwing :-)

maartenba commented Jul 5, 2017

OData specific imo, ping the respective support alias for the servers that are throwing :-)

@forki forki merged commit 4012a85 into fsprojects:master Jul 5, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 5, 2017

Member

thanks. I released it in 5.5 alpha channel. Let's see how it goes.

Member

forki commented Jul 5, 2017

thanks. I released it in 5.5 alpha channel. Let's see how it goes.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 10, 2017

Member

I knew this one would bite us. #2504 sigh

Member

forki commented Jul 10, 2017

I knew this one would bite us. #2504 sigh

@matthid matthid added this to NuGet API & Performance in Breaking Changes Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment