New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default NuGet source back to find-packages #2489

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
3 participants
@agross
Contributor

agross commented Jul 5, 2017

As noted by @fsoikin in aa5f1b7#commitcomment-22938166 I unintentionally removed the default NuGet source. Thanks for the heads-up, @fsoikin!

We should probably release 5.4.6 such that Paket doesn't stay broken until 5.5-alpha is released. I apologize for the trouble!

@forki forki merged commit 9cad66a into fsprojects:master Jul 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 6, 2017

Member

ok released as hotfix and in alpha channel. Thx

Member

forki commented Jul 6, 2017

ok released as hotfix and in alpha channel. Thx

@fsoikin

This comment has been minimized.

Show comment
Hide comment
@fsoikin

fsoikin Jul 6, 2017

Contributor

Since find-packages has a default source prepended, should find-package-versions be the same? In fact, perhaps it makes sense to factor out the common code from them both? Common sense would suggest that these two commands ought to use the same package-finding logic.

Contributor

fsoikin commented Jul 6, 2017

Since find-packages has a default source prepended, should find-package-versions be the same? In fact, perhaps it makes sense to factor out the common code from them both? Common sense would suggest that these two commands ought to use the same package-finding logic.

@agross agross deleted the agross:find-packages-default-source branch Jul 6, 2017

@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Jul 6, 2017

Contributor

@fsoikin This sounds useful! I never considered the case, I was recently more concerned about the command line in general :)

Contributor

agross commented Jul 6, 2017

@fsoikin This sounds useful! I never considered the case, I was recently more concerned about the command line in general :)

@fsoikin

This comment has been minimized.

Show comment
Hide comment
@fsoikin

fsoikin Jul 6, 2017

Contributor

Ok, I'll send a PR

Contributor

fsoikin commented Jul 6, 2017

Ok, I'll send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment