New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endsWithIgnoreCase #2562

Merged
merged 3 commits into from Jul 28, 2017

Conversation

Projects
None yet
3 participants
@0x53A
Contributor

0x53A commented Jul 26, 2017

if text is smaller than suffix, -1 (not found) passes the condition


Note: I have not verified if the changed test is actually correct, or not!

@0x53A

This comment has been minimized.

Show comment
Hide comment
@0x53A

0x53A Jul 26, 2017

Contributor

Is this a bug in the Mono allocator, or "just" an out-of-memory exception?

image

Contributor

0x53A commented Jul 26, 2017

Is this a bug in the Mono allocator, or "just" an out-of-memory exception?

image

@forki forki merged commit 577d0b6 into fsprojects:master Jul 28, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jul 28, 2017

Member

@0x53A To be honest I stopped looking at travis, all stuff like this which prints a native stack is categorized as mono bug (by me) and I'm working on getting rid of mono completely to make travis useful again...

Member

matthid commented Jul 28, 2017

@0x53A To be honest I stopped looking at travis, all stuff like this which prints a native stack is categorized as mono bug (by me) and I'm working on getting rid of mono completely to make travis useful again...

@0x53A 0x53A deleted the 0x53A:fix-endsWithIgnoreCase branch Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment