New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when paket outdated runs on a repo with a http zip dependency #2565

Merged
merged 3 commits into from Jul 28, 2017

Conversation

Projects
None yet
2 participants
@agross
Contributor

agross commented Jul 27, 2017

http zip dependencies will be extracted after download. As it stands, Paket
forces the download, see
https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/PackageAnalysis/FindOutdated.fs#L30

Without this fix, Paket fails to overwrite existing extracted files. Hence, delete the dependency's target folder before attempting the download.

Relates to #1845 (comment)

agross added some commits Jul 27, 2017

Fix exception when paket outdated runs on a repo with a http zip depe…
…ndency

http zip dependencies will be extracted after download. As it stands, Paket
forces the download, see
https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/PackageAnalysis/FindOutdated.fs#L30

Without this fix, Paket fails to overwrite existing extracted files.
Hence, delete the dependency's target folder before attempting the download.

@forki forki merged commit 27c522b into fsprojects:master Jul 28, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details

@agross agross deleted the agross:fix-outdated-with-http-zip-dependency branch Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment