New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix Feed Warnings and add blacklisting #2582

Merged
merged 2 commits into from Aug 17, 2017

Conversation

2 participants
@matthid
Member

matthid commented Aug 3, 2017

initial sketch at trying to remove repeated feed warnings and blacklist feeds.

I think this implementation has still some problems:

  • Feeds might be blacklisted on error as we even blacklist on valid but empty responses
    This is not trivial to fix and probably needs some trial and error with real feeds. And me going though all the old issues again ...
  • We decided to get rid of the warning on restore as well. This PR does not implement that part jet (as I want to do those changes separately to make this easier to review for now.

This should in effect reduce the amount of warnings and at the same time improve the performance by less "doomed to fail" requests. Lets see what the CI says.

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Aug 3, 2017

Member

CI is green - that makes me even more nervous ...

Member

matthid commented Aug 3, 2017

CI is green - that makes me even more nervous ...

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Aug 10, 2017

Member

can you please rebase? thanks

Member

forki commented Aug 10, 2017

can you please rebase? thanks

matthid added some commits Aug 3, 2017

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Aug 16, 2017

Member

Ok rebased. For some strange reason it feels slower, maybe wrong.
But at the very least we should do a prerelease to give all the people with "special" NuGet servers a chance to test it...

Member

matthid commented Aug 16, 2017

Ok rebased. For some strange reason it feels slower, maybe wrong.
But at the very least we should do a prerelease to give all the people with "special" NuGet servers a chance to test it...

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Aug 16, 2017

Member

CI failure is unrelated to this PR and in master as well.

Member

matthid commented Aug 16, 2017

CI failure is unrelated to this PR and in master as well.

@forki forki merged commit 609e654 into master Aug 17, 2017

0 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment