New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call paket if not necessary on dotnet pack. #2624

Merged
merged 1 commit into from Aug 17, 2017

Conversation

Projects
None yet
2 participants
@magne
Contributor

magne commented Aug 17, 2017

Add conditions to targets PaketDisableDirectPack and PaketOverrideNuspec. Solves #2621 and #2623.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Aug 17, 2017

Member
Member

forki commented Aug 17, 2017

@magne

This comment has been minimized.

Show comment
Hide comment
@magne

magne Aug 17, 2017

Contributor

I have absolutely no idea how the integration tests are written, so there are no tests that the issues are actually fixed.

Contributor

magne commented Aug 17, 2017

I have absolutely no idea how the integration tests are written, so there are no tests that the issues are actually fixed.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Aug 17, 2017

Member
Member

forki commented Aug 17, 2017

@forki forki merged commit fd4801e into fsprojects:master Aug 17, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@magne magne deleted the magne:dotnet-empty-references branch Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment