New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make packages folder optional #2638

merged 19 commits into from Aug 26, 2017
Jump to file or symbol
Failed to load files and symbols.
+2 −2
Diff settings


Just for now

Viewing a subset of changes. View all

GetFullPath can throw

  • Loading branch information...
matthid committed Aug 26, 2017
commit d3d1c80cfa45612d5fbf1b53d0b02a0703a93a57
@@ -357,9 +357,9 @@ let ExtractPackage(fileName:string, targetFolder, packageName:PackageName, versi
ZipFile.ExtractToDirectory(fileName, targetFolder)
| exn ->
let text = if detailed then sprintf "%s In rare cases a firewall might have blocked the download. Please look into the file and see if it contains text with further information." Environment.NewLine else ""
failwithf "Error during extraction of %s.%sMessage: %s%s" (Path.GetFullPath fileName) Environment.NewLine exn.Message text
let path = try Path.GetFullPath fileName with :? PathTooLongException -> sprintf "%s (!too long!)" fileName
raise <| Exception(sprintf "Error during extraction of %s.%s%s" path Environment.NewLine text, exn)
cleanup directory
ProTip! Use n and p to navigate between commits in a pull request.