New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PublicAPI #2643

Merged
merged 2 commits into from Aug 21, 2017

Conversation

Projects
None yet
2 participants
@forki
Member

forki commented Aug 21, 2017

No description provided.

forki added some commits Aug 21, 2017

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Aug 21, 2017

Member

I think this conflicts with #2638 on some lines

Member

matthid commented Aug 21, 2017

I think this conflicts with #2638 on some lines

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Aug 21, 2017

Member

haha so I are telling me to merge it asap so that I'm clear? ;)

Member

forki commented Aug 21, 2017

haha so I are telling me to merge it asap so that I'm clear? ;)

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Aug 21, 2017

Member

ok. I will keep it open until the other one is done.

Member

forki commented Aug 21, 2017

ok. I will keep it open until the other one is done.

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Aug 21, 2017

Member

For example ;).
No idea, tbh ideal timeslot for cleanup is after big changes finished, but tbf that is never the case.

Nono please merge if ready I can live with the consequences :P

Member

matthid commented Aug 21, 2017

For example ;).
No idea, tbh ideal timeslot for cleanup is after big changes finished, but tbf that is never the case.

Nono please merge if ready I can live with the consequences :P

@forki forki merged commit 73664a7 into master Aug 21, 2017

0 of 4 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment