New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash when a package contains an invalid file (ie is packaged inc… #2644

Merged
merged 2 commits into from Aug 21, 2017

Conversation

Projects
None yet
1 participant
@matthid
Member

matthid commented Aug 21, 2017

…orrectly) in the lib/profile* folder.

Before

$ ../../Paket/bin/paket.exe update
Paket version 5.85.8
Resolving packages for group Main:
 - Microsoft.Portable.FSharp.Core is pinned to 4.1.20
     Microsoft.Portable.FSharp.Core 4.1.20 was unlisted
The owner of Microsoft.Portable.FSharp.Core 4.1.20 has unlisted the package. This could mean that the package version is deprecated or shouldn't be used anymore.
Locked version resolution written to C:\Proj\testing\testpaketfailure\paket.lock
Installing into projects:
 - Creating model and downloading packages.
Performance:
 - Resolver: 558 milliseconds (1 runs)
    - Runtime: 343 milliseconds
    - Blocked (retrieving package details): 214 milliseconds (1 times)
 - Disk IO: 12 seconds
 - Average Request Time: 75 milliseconds
 - Number of Requests: 2
 - Runtime: 14 seconds
Paket failed with
-> tried to find portable profile 'profiles' but it is unknown to paket

After

$ ../../Paket/bin/paket.exe update
Paket version 5.89.0
Resolving packages for group Main:
 - Microsoft.Portable.FSharp.Core is pinned to 4.1.20
     Microsoft.Portable.FSharp.Core 4.1.20 was unlisted
The owner of Microsoft.Portable.FSharp.Core 4.1.20 has unlisted the package. This could mean that the package version is deprecated or shouldn't be used anymore.
C:\Proj\testing\testpaketfailure\paket.lock is already up-to-date
Installing into projects:
 - Creating model and downloading packages.
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\net20\FSharp.Core.dll'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\net20\FSharp.Core.optdata'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\net20\FSharp.Core.sigdata'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\net20\FSharp.Core.xml'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\net40\FSharp.Core.dll'
... snip some thousand lines ...
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\xamarinmac20\localize\ResponseFiles\LocComplete_FSharp.Core_ENU.txt'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\xamarinmac20\localize\ResponseFiles\OutputXML_FSharp.Core_ENU.xml'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\xamarinmac20\localize\RUS\FSharp.Core.dll.lct'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\xamarinmac20\localize\RUS\FSharp.Core.resources.dll'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\xamarinmac20\localize\TRK\FSharp.Core.dll.lct'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\xamarinmac20\localize\TRK\FSharp.Core.resources.dll'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\xamarinmac20\FSharp.Core.dll'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\xamarinmac20\FSharp.Core.optdata'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\xamarinmac20\FSharp.Core.sigdata'
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\xamarinmac20\FSharp.Core.xml'
Performance:
 - Resolver: 580 milliseconds (1 runs)
    - Runtime: 370 milliseconds
    - Blocked (retrieving package details): 209 milliseconds (1 times)
 - Disk IO: 13 milliseconds
 - Average Request Time: 77 milliseconds
 - Number of Requests: 2
 - Runtime: 3 seconds

matthid added some commits Aug 21, 2017

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Aug 21, 2017

Member

After the omit-warnings feature:

$ ../../Paket/bin/paket.exe update
Paket version 5.89.0
Resolving packages for group Main:
 - Microsoft.Portable.FSharp.Core is pinned to 4.1.20
     Microsoft.Portable.FSharp.Core 4.1.20 was unlisted
The owner of Microsoft.Portable.FSharp.Core 4.1.20 has unlisted the package. This could mean that the package version is deprecated or shouldn't be used anymore.
C:\Proj\testing\testpaketfailure\paket.lock is already up-to-date
Installing into projects:
 - Creating model and downloading packages.
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\net20\FSharp.Core.dll', please tell the package authors
Performance:
 - Resolver: 725 milliseconds (1 runs)
    - Runtime: 433 milliseconds
    - Blocked (retrieving package details): 291 milliseconds (1 times)
 - Disk IO: 11 milliseconds
 - Average Request Time: 137 milliseconds
 - Number of Requests: 2
 - Runtime: 3 seconds
Paket omitted '2319' warnings similar to the ones above. You can see them in verbose mode
Member

matthid commented Aug 21, 2017

After the omit-warnings feature:

$ ../../Paket/bin/paket.exe update
Paket version 5.89.0
Resolving packages for group Main:
 - Microsoft.Portable.FSharp.Core is pinned to 4.1.20
     Microsoft.Portable.FSharp.Core 4.1.20 was unlisted
The owner of Microsoft.Portable.FSharp.Core 4.1.20 has unlisted the package. This could mean that the package version is deprecated or shouldn't be used anymore.
C:\Proj\testing\testpaketfailure\paket.lock is already up-to-date
Installing into projects:
 - Creating model and downloading packages.
Could not detect any platforms from 'profiles' in 'C:\Proj\testing\testpaketfailure\packages\Microsoft.Portable.FSharp.Core\lib\profiles\net20\FSharp.Core.dll', please tell the package authors
Performance:
 - Resolver: 725 milliseconds (1 runs)
    - Runtime: 433 milliseconds
    - Blocked (retrieving package details): 291 milliseconds (1 times)
 - Disk IO: 11 milliseconds
 - Average Request Time: 137 milliseconds
 - Number of Requests: 2
 - Runtime: 3 seconds
Paket omitted '2319' warnings similar to the ones above. You can see them in verbose mode

@matthid matthid merged commit afbe69d into master Aug 21, 2017

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment