Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket.Restore.targets: use fixed version ([1.0]) #2654

Merged
merged 1 commit into from Aug 24, 2017

Conversation

Projects
None yet
3 participants
@0x53A
Copy link
Contributor

0x53A commented Aug 23, 2017

fixes #2653

When the version is specified without the braces, then it will choose any version equal or higher, with preference for the lowest.

Paket.Restore.targets: use fixed version ([1.0])
fixes #2653

When the version is specified without the braces, then it will choose any version equal or higher, with preference for the lowest.
@0x53A

This comment has been minimized.

Copy link
Contributor Author

0x53A commented Aug 23, 2017

I don't think the previous behavior would have caused any issues, but safe is safe ...

The only case I can think of is if the nuget cache for some reason didn't contain the exact version (paket restore should have put it there), but a higher one. Then nuget would have silently chosen the higher one.

@0x53A

This comment has been minimized.

Copy link
Contributor Author

0x53A commented Aug 23, 2017

Aaand github is down again?

image

image

@0x53A 0x53A closed this Aug 23, 2017

@0x53A 0x53A reopened this Aug 23, 2017

@forki forki merged commit d8a522a into fsprojects:master Aug 24, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@forki

This comment has been minimized.

Copy link
Member

forki commented Aug 24, 2017

thx!

@0x53A 0x53A deleted the 0x53A:patch-1 branch Aug 24, 2017

@0x53A

This comment has been minimized.

Copy link
Contributor Author

0x53A commented Aug 25, 2017

@forki

damn, sorry, can you please revert this?
This changes the behavior of dotnet pack.

Before it would generate a constraint >=, now it generates a constraint ==.

I don't think it is possible to tell nuget to use (==) for resolution, but use (>=) for the nuspec.
Since paket restore puts the exact version into the cache anyway, I don't think there is any realistic chance for something to go wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.