Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2733 #2737

Merged
merged 1 commit into from Sep 8, 2017
Merged

Fix for #2733 #2737

merged 1 commit into from Sep 8, 2017

Conversation

@sergey-tihon
Copy link
Member

@sergey-tihon sergey-tihon commented Sep 7, 2017

remove default 100sec timeout for Http dependencies download #2733

@@ -266,11 +266,13 @@ let downloadRemoteFiles(remoteFile:ResolvedSourceFile,destination) = async {
| Origin.HttpLink(origin), _ ->
let url = origin + remoteFile.Commit
let authentication = auth remoteFile.AuthKey url
let timeout = (Some(TimeSpan.FromDays(1.0)))

This comment has been minimized.

@forki

forki Sep 8, 2017
Member

o_O

This comment has been minimized.

@sergey-tihon

sergey-tihon Sep 8, 2017
Author Member

It is kind of Infinity, sometimes internet connection is really pure... =) I can spend 20min just to download 8Mb of new paket.exe from Github. Do you have better default for infinity timeout?

@forki forki merged commit 6dca624 into fsprojects:master Sep 8, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants