New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not evaluate all templates with --template switch #2769

Merged
merged 2 commits into from Sep 18, 2017

Conversation

Projects
None yet
2 participants
@lexarchik

lexarchik commented Sep 15, 2017

try to fix #2765

Lysogorskiy Aleksey added some commits Sep 15, 2017

@@ -171,11 +171,10 @@ let Pack(workingDir,dependenciesFile : DependenciesFile, packageOutputPath, buil
| _ -> true)
|> Array.map (fun (projectFile,templateFile') ->
allTemplateFiles.Remove(templateFile'.FileName) |> ignore
let merged = merge buildConfig buildPlatform version specificVersions projectFile templateFile'
let merged = lazy (merge buildConfig buildPlatform version specificVersions projectFile templateFile')

This comment has been minimized.

@lexarchik

lexarchik Sep 18, 2017

Idea of this fix is here - make "dangerous" operation lazy.
So exception only occur if project will actually be needed for packing.

@lexarchik

lexarchik Sep 18, 2017

Idea of this fix is here - make "dangerous" operation lazy.
So exception only occur if project will actually be needed for packing.

@@ -23,6 +23,9 @@ build/
[Bb]in/
[Oo]bj/
# Enable scenarios in integration tests
!integrationtests/scenarios/*/before/**

This comment has been minimized.

@forki

forki Sep 18, 2017

Member

is this a good thing!?

@forki

forki Sep 18, 2017

Member

is this a good thing!?

This comment has been minimized.

@lexarchik

lexarchik Sep 18, 2017

As far as i understand, idea is - all files in "test-scenario/before" folder is "setup" for test.
I think it's slightly easier to remove .idea, .dotsettings etc from commit than add ignored dlls/pdbs.

@lexarchik

lexarchik Sep 18, 2017

As far as i understand, idea is - all files in "test-scenario/before" folder is "setup" for test.
I think it's slightly easier to remove .idea, .dotsettings etc from commit than add ignored dlls/pdbs.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 18, 2017

Member

Thanks for taking care of this!

Member

forki commented Sep 18, 2017

Thanks for taking care of this!

@forki forki closed this Sep 18, 2017

@forki forki reopened this Sep 18, 2017

@forki forki merged commit aa7d3a1 into fsprojects:master Sep 18, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@lexarchik lexarchik deleted the lexarchik:i2765 branch Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment