New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding feature to verify the URL and credential correctness before storing them in paket.config #2781

Merged
merged 2 commits into from Sep 21, 2017

Conversation

Projects
None yet
2 participants
@ruhullahshah
Contributor

ruhullahshah commented Sep 20, 2017

While adding a source and its credentials to paket.config, it often happens that there are typos or the credentials do not authenticate, in that case adding these credentials and sources to paket.config becomes pointless. So we propose to have --verify option to augment the config command. It verifies the URL for the source and the credentials are correct.

@forki

cool stuff. only minor comments

@ruhullahshah

This comment has been minimized.

Show comment
Hide comment
@ruhullahshah

ruhullahshah Sep 20, 2017

Contributor

Thanks. I will update the code with the requested changes.

Contributor

ruhullahshah commented Sep 20, 2017

Thanks. I will update the code with the requested changes.

@forki

forki approved these changes Sep 21, 2017

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 21, 2017

Member

thx!

Member

forki commented Sep 21, 2017

thx!

@forki forki merged commit dddf2b2 into fsprojects:master Sep 21, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@ruhullahshah

This comment has been minimized.

Show comment
Hide comment
@ruhullahshah

ruhullahshah Sep 21, 2017

Contributor

You are welcome and thanks for the quick review, subsequent merge

Contributor

ruhullahshah commented Sep 21, 2017

You are welcome and thanks for the quick review, subsequent merge

@ruhullahshah ruhullahshah deleted the ruhullahshah:credential_url_verify_feature branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment