New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement stricter parsing in Requirements.parseRestrictionsLegacy (take 2) #2824

Merged
merged 2 commits into from Oct 6, 2017

Conversation

Projects
None yet
2 participants
@csmager
Contributor

csmager commented Oct 5, 2017

This supersedes reverted PR #2816, which caused issue #2822

It seems some existing files in the wild incorrectly used e.g. frameworks: net40 instead of framework: net40, and the previous 'loose' parsing would parse the resulting expression s net40 as = net40. The stricter version previously merged would bail as s isn't a valid framework.

This PR changes to first check for frameworks and then framework meaning the two are now interchangeable and existing files such as those described in #2822 will continue to work.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 6, 2017

Member

thank you so much!

Member

forki commented Oct 6, 2017

thank you so much!

@forki forki merged commit a73c5e6 into fsprojects:master Oct 6, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment