New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase package names in package cache (resolves #2676) #2826

Merged
merged 13 commits into from Oct 7, 2017

Conversation

Projects
None yet
2 participants
@julkwiec

julkwiec commented Oct 6, 2017

NuGet client used by dotnet CLI lowercases package names when saving them to packages folder and to the cache, while Paket doesn't touch the casing. On case-sensitive filesystems (i.e. on Mono under Linux) this causes dotnet restore to download the referenced packages again.

Repro steps (Windows + Docker)

  1. Checkout https://github.com/julkwiec/paket-dotnet-docker-test
  2. Open powershell, run run.ps1
  3. In the container, run dotnet restore --source /empty - it will fail since the package source directory is empty and AutoMapper is not yet present in the cache.
  4. Run mono paket.exe restore
  5. Run dotnet restore --source /empty again - dotnet still doesn't find the package in cache
  6. Lowercase the names of AutoMapper files and directories:
  • cd ~/.nuget/packages
  • mv AutoMapper automapper
  • cd automapper/6.1.1/
  • mv AutoMapper.6.1.1.nupkg automapper.6.1.1.nupkg
  • mv AutoMapper.6.1.1.nupkg.sha512 automapper.6.1.1.nupkg.sha512
  • mv AutoMapper.nuspec automapper.nuspec
  1. Run cd /test
  2. Run dotnet restore --source /empty. No failure this time - package was found in cache.

@forki sorry, I screwed up the previous PR.

@forki forki requested a review from matthid Oct 6, 2017

@forki forki merged commit 325c5e9 into fsprojects:master Oct 7, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 7, 2017

Member

thanks a lot!

Member

forki commented Oct 7, 2017

thanks a lot!

matthid added a commit that referenced this pull request Oct 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment