New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load scripts should only work on lock file - fixes #2372 #2834

Merged
merged 3 commits into from Oct 11, 2017

Conversation

Projects
None yet
2 participants
@forki
Member

forki commented Oct 10, 2017

fixes #2372

@forki forki requested a review from matthid Oct 10, 2017

@matthid

I guess you want to do the error handling changes in another pr. So it looks good to me.

Show outdated Hide outdated src/Paket.Core/Installation/ScriptGeneration.fs
@@ -438,10 +437,12 @@ let Restore(dependenciesFileName,projectFile,force,group,referencesFileNames,ign
s.Split([|';'|], StringSplitOptions.RemoveEmptyEntries)
|> Array.map (fun s -> s.Trim())
|> Array.choose FrameworkDetection.Extract)
let dependenciesFile = DependenciesFile.ReadFromFile(dependenciesFileName)

This comment has been minimized.

@matthid

matthid Oct 10, 2017

Member

So do we actually need a depsfile when this fails? Or should we warn and continue?

@matthid

matthid Oct 10, 2017

Member

So do we actually need a depsfile when this fails? Or should we warn and continue?

@forki forki merged commit 72f9bb8 into master Oct 11, 2017

0 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@forki forki deleted the i2372 branch Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment