New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor perf improvement for why command #2851

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
None yet
2 participants
@theimowski
Member

theimowski commented Oct 17, 2017

I got from 6s down to 3s on my box for the original case #2844

This replaces Map with IDictionary and cycle dependency prevention is a bit faster now

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 17, 2017

Member
Member

forki commented Oct 17, 2017

@forki forki merged commit 91bf6b0 into fsprojects:master Oct 18, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 18, 2017

Member

in #2853 I replaced the set with a hashset. Not sure if it's still correct?! Can you please review?

Member

forki commented Oct 18, 2017

in #2853 I replaced the set with a hashset. Not sure if it's still correct?! Can you please review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment