New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PAKET_VERSION posix compliant environment variable for bootstrapper #2857

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
4 participants
@TheAngryByrd
Contributor

TheAngryByrd commented Oct 20, 2017

What's the issue?
Paket boostrapper supplies a way to use environment variables to instruct it which version of paket to get.
https://github.com/fsprojects/Paket/blob/master/src/Paket.Bootstrapper/ArgumentParser.cs#L40

However PAKET.VERSION is not posix compliant. Instead of just changing it as it might be a breaking change I've just added a new variable compliant for posix and windows.

I've also added docs on how to obtain different versions using paket.exe.config or environment variables in the docs.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki
Member

forki commented Oct 20, 2017

/cc @vbfox

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Oct 20, 2017

Member

I was hit by this before so I’m happy that someone takes care of this :)

Member

matthid commented Oct 20, 2017

I was hit by this before so I’m happy that someone takes care of this :)

@vbfox

Code LGTM, just small fixes needed on doc :)

Show outdated Hide outdated docs/content/bootstrapper.md
Show outdated Hide outdated docs/content/bootstrapper.md
@vbfox

vbfox approved these changes Oct 21, 2017

@TheAngryByrd

This comment has been minimized.

Show comment
Hide comment
@TheAngryByrd

TheAngryByrd Nov 6, 2017

Contributor

Ping 🏓

Contributor

TheAngryByrd commented Nov 6, 2017

Ping 🏓

@forki forki merged commit 731f56a into fsprojects:master Nov 7, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment