New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using shasum/awk for comparing hashes of PaketRestoreCacheFile and PaketLockFilePath for speed boost on osx and linux #2870

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
2 participants
@TheAngryByrd
Contributor

TheAngryByrd commented Oct 27, 2017

This closes #2796 . This attempts to use the systems hashing programs in preference to reading in the whole paket lock file. For reasons unknown the ReadAllText can perform poorly on osx/linux.

In experiments on some of my builds this can shave off minutes.

Let me know if this seems reasonable.

Try using shasum/awk for comparing hashes of PaketRestoreCacheFile an…
…d PaketLockFilePath for speed boost on osx and linux
@forki

This comment has been minimized.

Show comment
Hide comment
@forki
Member

forki commented Oct 28, 2017

@forki forki merged commit 7eb7d29 into fsprojects:master Nov 7, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment