Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate nuspecs in IntermediateOutputPath #2871

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
3 participants
@johlrich
Copy link
Contributor

commented Oct 28, 2017

this is so they go in obj/Configuration/ instead of obj/

closes #2865

@forki

This comment has been minimized.

Copy link
Member

commented Oct 28, 2017

Pinging @matthid because I'm on vacation

@forki

This comment has been minimized.

Copy link
Member

commented Oct 29, 2017

@johlrich can you please take a look at the broken test in appveyor
(travis is expected to be red)

@johlrich johlrich force-pushed the johlrich:fix_2865 branch from 970d125 to ad0c22f Oct 29, 2017

@johlrich

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2017

Looks like I didn't test with the IntermediateOutputPath variable enough. That one includes the configuration and the target framework in the path. I switched back to $(BaseIntermediateOutputPath)$(Configuration)/ and will keep an eye on the appveyor result.

@forki

This comment has been minimized.

Copy link
Member

commented Oct 29, 2017

Mhm still red?

@forki

This comment has been minimized.

Copy link
Member

commented Oct 29, 2017

Maybe the test is no good?

@johlrich

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2017

Hmmmmm the test passes locally after switching. The test also fails here without the changes complaining about no description, and when looking at the in the scenario temp folder I see the same situation as the issue: an extra blank nuspec at obj root. Not sure why it's passing now.

Strange that I'm getting the opposite results as appveyor. Not really sure of a good way to troubleshoot atm. @forki any ideas?

My only thought was to somehow capture the scenario temp folder from the appveyor build to take a closer look in both scenarios, but not sure how to do that tbh.

@forki

This comment has been minimized.

Copy link
Member

commented Oct 29, 2017

@johlrich

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2017

@forki I think that's it. I isolated that one test and then ran it with DOTNET_EXE_PATH set to both the preview one that the build downloads (2.1.0-preview1-007002) and the one I have installed (2.0.2). The preview one fails, the install one passes.

Going to change to 2.0.2 so appveyor gets kicked off again with it to prove that out there. If that works then we'll have to see how you want to handle that. 🤞

@johlrich johlrich force-pushed the johlrich:fix_2865 branch from 95d4f54 to 850de22 Oct 29, 2017

@johlrich

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2017

More weirdness, the full build is currently churning through the integration tests on my machine with 2.0.2 but appveyor can't seem to get past restoring Paket.Core.preview3.

Edit: Build finished and all tests passed locally when using 2.0.2 + the RunIntegrationTests target

@forki

This comment has been minimized.

Copy link
Member

commented Oct 30, 2017

adjust path for nuspecs in either obj/ or obj/configuration/
nuspecs started appearing in obj/configuration/ with dotnetcli 2.0.2

@johlrich johlrich force-pushed the johlrich:fix_2865 branch from 850de22 to 8305ea9 Oct 30, 2017

@johlrich

This comment has been minimized.

Copy link
Contributor Author

commented Oct 30, 2017

Ok, it is now checking for existence in the new location and if it couldn't find it, falling back to the old location. Build finally green and worked with both cli versions here.

Not super familiar with MSBuild so let me know if there was a simpler way to do that since Exists doesn't seem to do wildcards

@matthid matthid merged commit 8305ea9 into fsprojects:master Oct 30, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.