New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove possibly nonexistent extension safely #2901

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
2 participants
@domdom
Contributor

domdom commented Nov 16, 2017

Fixes #2900

@domdom

This comment has been minimized.

Show comment
Hide comment
@domdom

domdom Nov 16, 2017

Contributor

I think there is actually a better solution, which is to use the Path.GetFileNameWithoutExtension method which seems to suit the use case perfectly. I can also replace other occurrences of this in the code base.

Pending feedback.

Contributor

domdom commented Nov 16, 2017

I think there is actually a better solution, which is to use the Path.GetFileNameWithoutExtension method which seems to suit the use case perfectly. I can also replace other occurrences of this in the code base.

Pending feedback.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 11, 2017

Member

thanks!

Member

forki commented Dec 11, 2017

thanks!

@forki forki merged commit cda98c3 into fsprojects:master Dec 11, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@domdom

This comment has been minimized.

Show comment
Hide comment
@domdom

domdom Dec 11, 2017

Contributor

I'm happy to help, thanks for the work on paket :)

Contributor

domdom commented Dec 11, 2017

I'm happy to help, thanks for the work on paket :)

@domdom domdom deleted the domdom:patch-2 branch Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment