New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement binding LOCKEDVERSION to particular group name #2943

Merged
merged 2 commits into from Dec 28, 2017

Conversation

Projects
None yet
2 participants
@eiriktsarpalis
Member

eiriktsarpalis commented Dec 22, 2017

This PR extends LOCKEDVERSION syntax so that it can be used for pinning to locked versions of individual groups. To my knowledge this shouldn't introduce any regressions to existing template files.

LOCKEDVERSION can be constrained to a particular group by suffixing
the placeholder with the particular group name.

dependencies
  FSharp.Core >= LOCKEDVERSION-NetStandard
@eiriktsarpalis

This comment has been minimized.

Show comment
Hide comment
@eiriktsarpalis

eiriktsarpalis Dec 22, 2017

Member

The failing integration test fails on wrong framework given seems unrelated to my changes

Member

eiriktsarpalis commented Dec 22, 2017

The failing integration test fails on wrong framework given seems unrelated to my changes

@eiriktsarpalis

This comment has been minimized.

Show comment
Hide comment
@eiriktsarpalis
Member

eiriktsarpalis commented Dec 27, 2017

(bump)

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 27, 2017

Member
Member

forki commented Dec 27, 2017

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 28, 2017

Member

thanks

Member

forki commented Dec 28, 2017

thanks

@forki forki merged commit b6acebb into fsprojects:master Dec 28, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@eiriktsarpalis

This comment has been minimized.

Show comment
Hide comment
@eiriktsarpalis

eiriktsarpalis Dec 28, 2017

Member

Thank you

Member

eiriktsarpalis commented Dec 28, 2017

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment