New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Incorrect time metrics" (#2510) #2946

Merged
merged 1 commit into from Dec 28, 2017

Conversation

Projects
None yet
3 participants
@enovales
Contributor

enovales commented Dec 27, 2017

This is a fix for #2510 . It tracks the start and end times of operations, and then coalesces overlapping operations until only discontiguous spans remain. The durations of these spans are then used to calculate the overall time spent per category.�

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 27, 2017

Member

Cool!

@matthid can you please review this?

Member

forki commented Dec 27, 2017

Cool!

@matthid can you please review this?

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Dec 27, 2017

Member

It's a bit of a strange way of doing it and we might want to prefer DateTime.UtcNow, but it could work.
The build is red ;)

As I don't have a better suggestion at the time on how to fix this we can try it :)

Member

matthid commented Dec 27, 2017

It's a bit of a strange way of doing it and we might want to prefer DateTime.UtcNow, but it could work.
The build is red ;)

As I don't have a better suggestion at the time on how to fix this we can try it :)

@forki forki merged commit cefe1da into fsprojects:master Dec 28, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 28, 2017

Member

thanks

Member

forki commented Dec 28, 2017

thanks

@eriawan eriawan referenced this pull request Jan 3, 2018

Closed

Incorrect time metrics #2510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment