New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a few things when framework: lines are parsed in template #2969

Merged
merged 2 commits into from Jan 10, 2018

Conversation

Projects
None yet
4 participants
@vbfox
Contributor

vbfox commented Jan 10, 2018

Had to hunt some oddities due to that today 馃槈

  • Accept the framework:foo format (without a space after ":")
  • Fail on unknown frameworks instead of silently ignoring the framework and continuing as if nothing was specified

Note: I choose to fail hard using failwith instead of wiring the Choice<,> around as dependency parsing in getDependencyByLine already does that.

vbfox added some commits Jan 10, 2018

Fixes a few things when framework: lines are parsed in template
* Accept the framework:foo format (without a space after ":")
* Fail on unknown frameworks instead of silently ignoring
@enricosada

This comment has been minimized.

Show comment
Hide comment
@enricosada

enricosada Jan 10, 2018

Collaborator

馃憤 ci error is unrelated

Collaborator

enricosada commented Jan 10, 2018

馃憤 ci error is unrelated

@forki forki merged commit 4ca6157 into fsprojects:master Jan 10, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jan 10, 2018

Member

Technically I think this is a breaking change, let鈥檚 see what happens...

Member

matthid commented Jan 10, 2018

Technically I think this is a breaking change, let鈥檚 see what happens...

@enricosada

This comment has been minimized.

Show comment
Hide comment
@enricosada

enricosada Jan 10, 2018

Collaborator

silent was bad => bug.

be less strict on input file (hand edited by user) is not too bad.
i think is a situation of Generous on input, strict on output.

Collaborator

enricosada commented Jan 10, 2018

silent was bad => bug.

be less strict on input file (hand edited by user) is not too bad.
i think is a situation of Generous on input, strict on output.

@vbfox vbfox deleted the vbfox:template_framework_parsing_fixes branch Jan 10, 2018

@vbfox

This comment has been minimized.

Show comment
Hide comment
@vbfox

vbfox Jan 10, 2018

Contributor

I consider it more of a bug fix even if there are some edge cases that it could break (Invalid file and the user never noticed and started to depend on invalid framework being merged with no-framework blocks)

Contributor

vbfox commented Jan 10, 2018

I consider it more of a bug fix even if there are some edge cases that it could break (Invalid file and the user never noticed and started to depend on invalid framework being merged with no-framework blocks)

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jan 10, 2018

Member

I was just saying, I think we reverted a similar change before. Don鈥檛 get me wrong I like the change ;)
Also my memory might be bad

Member

matthid commented Jan 10, 2018

I was just saying, I think we reverted a similar change before. Don鈥檛 get me wrong I like the change ;)
Also my memory might be bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment