New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NuGet2 async query fallback to skip NotFound/404, fixes #2847, fixes #2972 #2993

Merged
merged 2 commits into from Jan 18, 2018

Conversation

Projects
None yet
4 participants
@viktor-svub
Contributor

viktor-svub commented Jan 18, 2018

NuGet2 async queries with different case sensitivity and normalization settings were cancelled on any exception, including NotFound/404, resulting in race-conditions and inconsistent behavior as described in issue #2847 and issue #2972.

Fixed the race by skipping and logging NotFound/404 on these queries so another format may succeed.

viktor-svub and others added some commits Jan 18, 2018

Merge pull request #2 from fsprojects/master
Merge upstream 5.131.1

@forki forki requested a review from matthid Jan 18, 2018

@forki forki merged commit 9cacbb5 into fsprojects:master Jan 18, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@forki

This comment has been minimized.

Member

forki commented Jan 18, 2018

Awesome. Thank you!

@matthid

Lets see how that works out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment