New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce next-link warning to once per method/endpoint, omitting the query, fixes #2848 #2994

Merged
merged 2 commits into from Jan 18, 2018

Conversation

Projects
None yet
2 participants
@viktor-svub
Contributor

viktor-svub commented Jan 18, 2018

Warnings for empty next-link result are repeated for every single occurrence, which caused console/log flooding when we use Artifactory for all of our internal dependencies (repository behavior fix or replacement does not seem negotiable).

Reduced the warnings to once per specific API endpoint and shortening the report by trimming the query, which only contains redundant information.

viktor-svub and others added some commits Jan 18, 2018

Merge pull request #2 from fsprojects/master
Merge upstream 5.131.1
@@ -73,7 +73,11 @@ let private followODataLink auth url =
match atLeastOneFailed with
| Some i ->
traceWarnfn "At least one 'next' link (index %d) returned a empty result (noticed on '%O'): ['%s']" i url (System.String.Join("' ; '", linksToFollow))
let mutable uri = null // warn once per apecific API endpoint, but try to cut the query

This comment has been minimized.

@forki

forki Jan 18, 2018

Member

typo

@forki forki requested a review from matthid Jan 18, 2018

@forki forki merged commit ba482b8 into fsprojects:master Jan 18, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment