New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace not-found and blacklist warnings as actual warnings #2997

Merged
merged 1 commit into from Jan 18, 2018

Conversation

Projects
None yet
2 participants
@viktor-svub
Contributor

viktor-svub commented Jan 18, 2018

Specific explicitly handled and repeated "errors" are changed to "warn if not before" to avoid stderr writes and/or console/log flooding when the resolver actually continues and can succeed.
Trace not-found and blacklist warnings as actual warnings, and only once per query and source combination.

@@ -301,7 +312,7 @@ let rec private getPackageDetails alternativeProjectRoot root force (parameters:
return! tryV3 nugetSource force
with
| exn ->
eprintfn "Possible Performance degradation, V3 was not working: %s" exn.Message
traceWarnfn "Possible Performance degradation, V3 was not working: %s" exn.Message

This comment has been minimized.

@forki

forki Jan 18, 2018

Member

/cc @matthid good idea?

@forki

This comment has been minimized.

Member

forki commented Jan 18, 2018

wow you are on fire!

@forki forki merged commit 451d5ef into fsprojects:master Jan 18, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment