New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub sources in PublicAPI and CLI #3023

Merged
merged 15 commits into from Mar 1, 2018

Conversation

Projects
None yet
4 participants
@frelon
Contributor

frelon commented Feb 1, 2018

work in progress for implementing Git, GitHub, Gist and Http sources in CLI tool and PublicAPI

@frelon frelon referenced this pull request Feb 1, 2018

Open

Using Git, GitHub, Gist and Http sources in PublicAPI #3014

2 of 4 tasks complete
@enricosada

This comment has been minimized.

Collaborator

enricosada commented Feb 1, 2018

about cli, @forki @matthid what do you think?

paket git add .. // and list remove etc
paket github add ..
paket http add ..

like git remote?

add lot of cmd add-git remove-git etc is annoying

Asking because i'd like something like that for repotool too

@frelon

This comment has been minimized.

Contributor

frelon commented Feb 21, 2018

@enricosada I changed the cli and added the functions in AddProcess etc. Now you can run

paket github add fsprojects/paket

and it generates the paket.dependencies and paket.lock file correctly. It also supports the version, file and group parameters.

@forki

This comment has been minimized.

Member

forki commented Feb 21, 2018

so no longer WIP?
@matthid @enricosada can you please review?

@frelon

This comment has been minimized.

Contributor

frelon commented Feb 21, 2018

I could clean up the empty functions AddHttp, AddGit etc if you want to merge only the Github-functionality.
Then it's no longer WIP, no.

@frelon frelon changed the title from [WIP] Sources in PublicAPI and CLI to Sources in PublicAPI and CLI Feb 22, 2018

@forki forki requested a review from enricosada Feb 26, 2018

@frelon frelon changed the title from Sources in PublicAPI and CLI to Add GitHub sources in PublicAPI and CLI Feb 28, 2018

@forki

This comment has been minimized.

Member

forki commented Mar 1, 2018

thanks!

@forki forki merged commit 533d36e into fsprojects:master Mar 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@frelon frelon deleted the frelon:sources-in-publicapi branch Mar 1, 2018

@@ -625,6 +647,7 @@ with
member this.Usage =
match this with
| Add _ -> "add a new dependency"
| Github _ -> "commands to manipulate gihub repository references"

This comment has been minimized.

@agross

agross Mar 3, 2018

Contributor

Could you please change gihub to GitHub?

This comment has been minimized.

@frelon

frelon Mar 3, 2018

Contributor

Absolutely! Opened #3100 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment