New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs/3074 bad request #3078

Merged
merged 2 commits into from Feb 27, 2018

Conversation

Projects
None yet
3 participants
@haf
Member

haf commented Feb 26, 2018

My editor also trimmed trailing whitespace. I hope that's fine, or I'll separate it.

haf added some commits Feb 26, 2018

@matthid

This comment has been minimized.

Member

matthid commented Feb 26, 2018

Yes trimming whitespace is usually fine. However, can you mark the actual change. I reviewed it briefly and cannot find the actual change oO. Maybe I'm blind.

@matthid

This comment has been minimized.

Member

matthid commented Feb 26, 2018

So the problem was that the message was not good enough?

@forki forki merged commit 62eb88d into fsprojects:master Feb 27, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@haf haf deleted the haf:bugs/3074-bad-request branch Feb 27, 2018

@haf

This comment has been minimized.

Member

haf commented Feb 27, 2018

@matthid No it was not; it was just a way to see what GCloud was responding.

The real issue is still open. The repro is simple; make a single http dep to that URI. I haven't gone further myself.

@haf

This comment has been minimized.

Member

haf commented Feb 27, 2018

However, you can replace that with #3079 - it's a similar issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment