New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NETCoreApp2.1 and UAP10.0.16300 tfms #3094

Merged
merged 5 commits into from Mar 1, 2018

Conversation

Projects
None yet
2 participants
@JarnoNijboer
Contributor

JarnoNijboer commented Feb 27, 2018

Possible fix for #3081

When restoring fake-bootstrap, errors were appearing about .NETCoreApp2.1 and UAP10.0.16300 TFMs
Added these TFMs to FrameworkHandling.fs and fixed broken tests. If more changes are needed, let me know

@forki

This comment has been minimized.

Member

forki commented Feb 28, 2018

the fix looks good, but still red integration tests.

@JarnoNijboer

This comment has been minimized.

Contributor

JarnoNijboer commented Feb 28, 2018

Yeah, I broke tests while trying to fix them, will look into it.

@forki

This comment has been minimized.

Member

forki commented Feb 28, 2018

can you please merge master. that may fix couple of tests

JarnoNijboer added some commits Feb 28, 2018

@JarnoNijboer

This comment has been minimized.

Contributor

JarnoNijboer commented Feb 28, 2018

Integration tests are passing on local machine, except 1:

1) Error : Paket.IntegrationTests.NuGetV3Specs.#2700-1 v3 works properly
System.Exception : Paket failed with
-> Unable to retrieve package versions for 'Microsoft.CSharp'
@forki

This comment has been minimized.

Member

forki commented Mar 1, 2018

thank you!

@forki forki merged commit bd1efaa into fsprojects:master Mar 1, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@JarnoNijboer JarnoNijboer deleted the JarnoNijboer:tfms-uap10.0.16300-netcoreapp2.1 branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment