New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to a more recent version of argu #3112

Merged
merged 5 commits into from Mar 13, 2018

Conversation

Projects
None yet
3 participants
@vbfox
Contributor

vbfox commented Mar 12, 2018

To get a few perf optimizations, waiting for the next ones

@@ -23,7 +23,7 @@ nuget NUnit.Console
nuget NUnit3TestAdapter version_in_path: true
clitool dotnet-mergenupkg
github fsharp/FAKE src/app/FakeLib/Globbing/Globbing.fs
github fsharp/FAKE:0341a2e614eb2a7f34607cec914eb0ed83ce9add src/app/FakeLib/Globbing/Globbing.fs

This comment has been minimized.

@matthid

matthid Mar 12, 2018

Member

The file moved to /src/legacy/FakeLib/Globbing/Globbing.fs that was probably the problem?

@@ -700,7 +700,7 @@ with
| Version -> "show Paket version"
| From_Bootstrapper -> "call coming from the '--run' feature of the bootstrapper"
let commandParser = ArgumentParser.Create<Command>(programName = "paket", errorHandler = new ProcessExiter())
let commandParser = ArgumentParser.Create<Command>(programName = "paket", errorHandler = new ProcessExiter(), checkStructure = false)

This comment has been minimized.

@matthid

matthid Mar 12, 2018

Member

Just out of curiosity what is the impact of this? Is there an impact?

This comment has been minimized.

@vbfox

vbfox Mar 13, 2018

Contributor

On performance it's faster :)

It also doesn't check the argument DU for incoherences, but it's forced in unit tests so it would fail there.

@forki forki merged commit fa80569 into fsprojects:master Mar 13, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Member

forki commented Mar 13, 2018

Thanks

@forki

This comment has been minimized.

Member

forki commented Mar 13, 2018

released in 5.150.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment