New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the optimization for restore bypassing argu #3113

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
3 participants
@vbfox
Contributor

vbfox commented Mar 12, 2018

The current optimization to bypass argu doesn't work because the first element in the arguments is the current executable path.

So I fixed it and also added support for restore --project that the SDK projects target uses, and for install as it's one of the most used command

@matthid

This comment has been minimized.

Member

matthid commented Mar 12, 2018

I limited myself to "restore" without arguments by design, because I didn't want to introduce our own argument parser. But it seems like we have to give up and implement our own over time ;)

@forki forki merged commit 018dc5b into fsprojects:master Mar 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vbfox

This comment has been minimized.

Contributor

vbfox commented Mar 13, 2018

@matthid adding the variants was just to get the perf gain in more cases. The bugfix was to ignore the first element of the array, the previous code never triggered

@forki

This comment has been minimized.

Member

forki commented Mar 13, 2018

released in 5.150.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment