New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping direct dependencies distinct from external locks #3159

Merged
merged 5 commits into from Apr 18, 2018

Conversation

Projects
None yet
2 participants
@viktor-svub
Contributor

viktor-svub commented Apr 18, 2018

just cosmetic and debuggability improvements, as we move to use the external_lock feature 馃憤

  • introduced new PackageRequirementSource to track external lock files referenced from dependency files
  • updated code relying on the union to behave correctly with the new type -- currently equal to normal dependency file, except for logging

viktor-svub added some commits Feb 26, 2018

@forki

This comment has been minimized.

Member

forki commented Apr 18, 2018

@viktor-svub

This comment has been minimized.

Contributor

viktor-svub commented Apr 18, 2018

Not yet -- currently I plan to use this internally to enforce consistent external dependencies across our builds. We create lower hundreds of both interim and production components, and they use some external dependencies which we want to update in controlled way, and still keep them part of the resolve graph, to enforce compatibility with the unfixed ones.

@forki forki merged commit ac87a9f into fsprojects:master Apr 18, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Member

forki commented Apr 18, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment