New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect framework restrictions in the lockfile. #3176

Merged
merged 1 commit into from May 8, 2018

Conversation

Projects
None yet
2 participants
@matthid
Member

matthid commented Apr 29, 2018

Seems like the resolver currently just returns the "first" framework restrictions of a transitive dependency. Even if a transitive appears multiple times in the dependency tree with different restrictions.
afaics the resolver is working correctly internally but just returns the wrong restriction.

@forki forki merged commit a1b825b into master May 8, 2018

2 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@forki forki deleted the fix_restriction_of_transitives branch May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment