Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update magic mode file location #3197

Merged
merged 3 commits into from May 17, 2018

Conversation

Projects
None yet
3 participants
@BlythMeister
Copy link
Contributor

BlythMeister commented May 11, 2018

Some companies (mine included) block the running of exe in any of the app data folders as this is where malware typically embeds itself.
It is possible to put folder exclusions into group policy, but since paket was just going into the root of the temp folder it is not possible to unblock it.
This change will put the downloaded magic paket.exe into a paket folder.

Update magic mode file location
Some companies (mine included) block the running of exe in any of the app data folders as this is where malware typically embeds itself.
It is possible to put folder exclusions into group policy, but since paket was just going into the root of the temp folder it is not possible to unblock it.
This change will put the downloaded magic paket.exe into a paket folder.
@forki

This comment has been minimized.

Copy link
Member

forki commented May 11, 2018

/cc @vbfox

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

BlythMeister commented May 11, 2018

@forki are the ci failures mine? On appveyor one of the builds pass, but on all others they fail.
It's kinda confusing.

@forki

This comment has been minimized.

Copy link
Member

forki commented May 11, 2018


return Path.Combine(fileSystemProxy.GetTempPath(), targetName);
var targetFolder = Path.Combine(fileSystemProxy.GetTempPath(), "paket");
Directory.CreateDirectory(targetFolder);

This comment has been minimized.

@vbfox

vbfox May 11, 2018

Contributor

Please use fileSystemProxy here (it should have a CreateDirectory method too)

This comment has been minimized.

@BlythMeister

BlythMeister May 11, 2018

Author Contributor

Done 👍🏼

@vbfox

vbfox approved these changes May 12, 2018

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

BlythMeister commented May 17, 2018

@forki @vbfox is this good to merge now?

@vbfox

This comment has been minimized.

Copy link
Contributor

vbfox commented May 17, 2018

Yes I think so, I approved the changes but don't have access to the repo to merge.

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

BlythMeister commented May 17, 2018

Oh sorry, I didn't realise that, just waiting on @forki then 😂

@forki forki merged commit a1bf35b into fsprojects:master May 17, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.