Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer search for CredentialProviders on an empty path. #3214

Merged
merged 1 commit into from May 23, 2018

Conversation

Projects
None yet
3 participants
@ninjarobot
Copy link
Contributor

ninjarobot commented May 19, 2018

In some unusual scenarios like a paket mkbundle, Path.GetDirectoryName on an Assembly.Location returns an empty string. When that happens, Directory.EnumerateFiles will eventually call Path.InsecureGetFullPath on mono, resulting in this error:

System.ArgumentException: The specified path is not of a legal form (empty).

coming from here.

Switching to String.IsNullOrEmpty addresses that issue.

@forki

This comment has been minimized.

Copy link
Member

forki commented May 23, 2018

thx

@forki forki merged commit 8be8743 into fsprojects:master May 23, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ninjarobot ninjarobot deleted the ninjarobot:mono_enumeratefiles_fix branch May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.