Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env vars fix #3293

Merged
merged 2 commits into from Jul 17, 2018

Conversation

Projects
None yet
3 participants
@lexarchik
Copy link
Contributor

lexarchik commented Jul 12, 2018

fix #3290
plus expand env vars in env vars values to correctly process PATH like %SystemRoot% or %UserProfile%/something

else "")
else ""
with
| _ -> "")

This comment has been minimized.

@inosik

inosik Jul 12, 2018

Contributor

Should we print the exception message and the bad path?

This comment has been minimized.

@lexarchik

lexarchik Jul 12, 2018

Author Contributor

Maybe always print something like "Error when searching <file> in <path>" and print exception message only in verbose mode?
Or print everything only in verbose?

This comment has been minimized.

@inosik

inosik Jul 12, 2018

Contributor

I'd print that as a warning, otherwise people might not even be aware that they have something invalid in their PATH.

This comment has been minimized.

@lexarchik

lexarchik Jul 12, 2018

Author Contributor

I think it can be confusing to see warn about some strange path after hit paket restore in random repository.
And in tryFindFile we dont know source of dirs parameter.
So i'm inclined to verbose-only trace.

@lexarchik lexarchik force-pushed the lexarchik:env_vars_fix branch from 544ce80 to edde814 Jul 12, 2018

@forki

This comment has been minimized.

Copy link
Member

forki commented Jul 17, 2018

thx

@forki forki merged commit edde814 into fsprojects:master Jul 17, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.