Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert impact of https://github.com/dotnet/corefx/issues/31098 by using WinHttpHandler #3307

Merged
merged 8 commits into from Jul 30, 2018

Conversation

Projects
None yet
2 participants
@matthid
Copy link
Member

matthid commented Jul 22, 2018

In essence the netcore2.1 release broke some use-cases for fake 5 and paket (well the netcore version if it ever exists and Paket.Core) - this tries to restore the old behavior.

See dotnet/corefx#31098

I noticed the following warnings after paket install (but they might have been there before that as I don't see any of those versions changed in this PR):

  Consider app.config remapping of assembly "System.ComponentModel.TypeConverter, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" from Version "4.1.1.0" [] to Version "4.1.2.0" [C:\Users\matth\.nuget\packages\netstandard.library\2.0.1\build\netstandard2.0\ref\System.ComponentModel.TypeConverter.dll] to solve conflict and get rid of warning.
  Consider app.config remapping of assembly "System.Runtime.Serialization.Primitives, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" from Version "4.1.2.0" [] to Version "4.1.3.0" [C:\Users\matth\.nuget\packages\netstandard.library\2.0.1\build\netstandard2.0\ref\System.Runtime.Serialization.Primitives.dll] to solve conflict and get rid of warning.
  Consider app.config remapping of assembly "System.Collections.NonGeneric, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" from Version "4.0.2.0" [] to Version "4.0.3.0" [C:\Users\matth\.nuget\packages\netstandard.library\2.0.1\build\netstandard2.0\ref\System.Collections.NonGeneric.dll] to solve conflict and get rid of warning.
  Consider app.config remapping of assembly "System.Xml.XmlDocument, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" from Version "4.0.2.0" [] to Version "4.0.3.0" [C:\Users\matth\.nuget\packages\netstandard.library\2.0.1\build\netstandard2.0\ref\System.Xml.XmlDocument.dll] to solve conflict and get rid of warning.
@matthid

This comment has been minimized.

Copy link
Member Author

matthid commented Jul 22, 2018

The type 'WinHttpHandler' is not defined oO. I thought I added the nuget package...

@matthid

This comment has been minimized.

Copy link
Member Author

matthid commented Jul 22, 2018

The API seems to be compatible for >=net46 only and we still have net45 :(

@matthid

This comment has been minimized.

Copy link
Member Author

matthid commented Jul 23, 2018

I'm not sure if the build errors are related to this pr or if I was just unlucky. Some builds in the matrix are definitely green...

matthid added some commits Jul 28, 2018

@matthid

This comment has been minimized.

Copy link
Member Author

matthid commented Jul 28, 2018

It makes no sense that travis started to fail with this PR:

  • All changes are in #if blocks and the full-framework build is exactly the same as before this PR
  • Even if the new code is somehow executed it is in a if isWindows then block in addition to the #if

what the hell?

@matthid

This comment has been minimized.

Copy link
Member Author

matthid commented Jul 28, 2018

Maybe because of the paket update or something like that. I'm pretty positive that it is not related to the code change at all.

@@ -4,6 +4,7 @@
<TargetFramework>netstandard2.0</TargetFramework>
<PaketCoreSourcesDir>..\Paket.Core</PaketCoreSourcesDir>
<DefineConstants>NO_BOOTSTRAPPER;NO_CONFIGURATIONMANAGER;CUSTOM_WEBPROXY;$(DefineConstants)</DefineConstants>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>

This comment has been minimized.

@matthid

matthid Jul 28, 2018

Author Member

paket added this, maybe mono doesn't like that

@matthid

This comment has been minimized.

Copy link
Member Author

matthid commented Jul 28, 2018

Intesting. master seems to have the same problem now. So I guess I was unlucky again and something changed outside of this PR

fix
@matthid

This comment has been minimized.

Copy link
Member Author

matthid commented Jul 28, 2018

@matthid

This comment has been minimized.

Copy link
Member Author

matthid commented Jul 28, 2018

Ok:

  • AppVeyor is now running besides two tests. I hope @forki can take a look at one of them next week. The second looks like some regression in the FLAKY testsuite.
  • Travis is now broken globally for us because of the linked issue.

@forki forki merged commit c4c58c0 into master Jul 30, 2018

0 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details

matthid added a commit that referenced this pull request Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.