Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow addition of <EmbedInteropTypes> for Nuget packages #3314

Merged
merged 1 commit into from Jul 30, 2018

Conversation

Projects
None yet
2 participants
@ruhullahshah
Copy link
Contributor

ruhullahshah commented Jul 27, 2018

  • Problem
    NuGet package reference with a COM interop DLL, <EmbedInteropTypes>True</EmbedInteropTypes> needs to be managed manually and paket update removes the flag.

  • Solution
    Provide a way to express this through existing paket.references syntax
    PkgName embed_interop_types: true

  • Related Issues
    #910

There might be some failing testcases but adding the PR to open up the discussion.

@forki

This comment has been minimized.

Copy link
Member

forki commented Jul 30, 2018

thanks!

@forki forki merged commit 6282a73 into fsprojects:master Jul 30, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@ruhullahshah

This comment has been minimized.

Copy link
Contributor Author

ruhullahshah commented Jul 30, 2018

You are welcome. Thanks for taking care of the failing tests.

@ruhullahshah ruhullahshah deleted the ruhullahshah:support_embed_interop_types_flag_for_nuget_references branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.