Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use WinHttpHandler for downloading as well (Fixup of 3307) #3342

Merged
merged 2 commits into from Aug 25, 2018

Conversation

Projects
None yet
1 participant
@matthid
Copy link
Member

matthid commented Aug 23, 2018

#3307
fsharp/FAKE#2029

It took me a while to find why it still wasn't working until I realized that only "downloads" were not working, everything else did work fine. Reason is that we used a different API for downloading then for all other calls. This PR just falls back to the already existing logic instead of duplicating everything.

matthid added some commits Aug 23, 2018

allow to opt-in to the new "faster" implementation via PAKET_SYSTEM_N…
…ET_HTTP_USESOCKETSHTTPHANDLER (mostly for testing)

@matthid matthid merged commit 16cbe07 into master Aug 25, 2018

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@matthid

This comment has been minimized.

Copy link
Member Author

matthid commented Aug 25, 2018

@forki I tried to release this but failed because my nugetkey is no longer valid. Can you update my nuget account to the packages or maybe we could create an organization like we did for fake?

Feel free to straight up release from master (already updated the release notes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.