Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket pack with `--template` fails trying to load the dependencies of templates who should be ignored instead #3363

Merged

Conversation

Projects
None yet
2 participants
@enricosada
Copy link
Collaborator

enricosada commented Sep 17, 2018

When specified the --template argument, the paket pack search also for project references (finding all the paket.template files in same directory of project files)

Doing so, paket try to load and validate the found paket.template files.
But these template files may be not needed (like when --template is specified), and some may fail to load (for example a files required doesnt exists, because was not built)

This PR refactor the code to parse the found paket.template files, and just load these when are needed (if are not needed, are not validated, just considered for metadata)

enricosada added some commits Sep 12, 2018

add failing test: doing `paket pack` if `--template` is specified, sh…
…ouldn't consider others template files.

in the regression test, the `paket pack` failed because tried to load `PaketBug2`template file, who
isnt ready (a file required doesn't exists)
validate templates (like load) only when they need to be packed
otherwise some templates may be validated (failing if required files doesnt exists), when are not needed
@enricosada

This comment has been minimized.

Copy link
Collaborator Author

enricosada commented Sep 17, 2018

@forki @matthid ready to review and merge for a new release.

test failure are unrelated (master already fails, ref appveyor )

@enricosada enricosada requested a review from forki Sep 17, 2018

@forki forki merged commit 87c8849 into fsprojects:master Sep 18, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@forki

This comment has been minimized.

Copy link
Member

forki commented Sep 18, 2018

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.