New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetcoreApp3.0 support #3367

Merged
merged 2 commits into from Sep 20, 2018

Conversation

Projects
None yet
2 participants
@forki
Member

forki commented Sep 19, 2018

No description provided.

forki added some commits Sep 19, 2018

@forki forki referenced this pull request Sep 19, 2018

Merged

New netcore2.2 tags #3366

@enricosada

This comment has been minimized.

Show comment
Hide comment
@enricosada

enricosada Sep 19, 2018

Collaborator

I checked in code and should inherit from netcoreapp2.2 and netstandard 2.0

maybe adding an unit test like

let ``netcoreapp2.2 should be compatible with netstandard2.0``() =
can help maintainance

Collaborator

enricosada commented Sep 19, 2018

I checked in code and should inherit from netcoreapp2.2 and netstandard 2.0

maybe adding an unit test like

let ``netcoreapp2.2 should be compatible with netstandard2.0``() =
can help maintainance

@forki forki closed this Sep 19, 2018

@forki forki reopened this Sep 19, 2018

@forki forki merged commit eda0548 into master Sep 20, 2018

1 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@forki forki deleted the netcore3 branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment