Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Simplifier removing item if it has settings or version requirements #3523

Merged
merged 9 commits into from Apr 2, 2019

Conversation

Projects
None yet
2 participants
@BlythMeister
Copy link
Contributor

commented Mar 18, 2019

I noticed that when i had any settings or version requirements in references/dependencies files and run a simplify it would remove these items and therefore remove the settings.

Now, as well as the item being implied as a transitive dependency, it also needs to have no settings or version requirements in order to be removed.

BlythMeister added some commits Mar 18, 2019

Update existing tests to remove version numbers
With version numbers these tests fail as nothing gets removed.
@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

@forki are these build failures mine, or pre-existing. It is quite confusing 😕

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

This one is ready

BlythMeister added some commits Mar 28, 2019

Update simplify documentation to reflect this change
Removal of the warning as this is no longer an issue :)
@forki

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

can you please merge with master?

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

@forki done :)

@forki forki merged commit 483625b into fsprojects:master Apr 2, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@BlythMeister BlythMeister referenced this pull request Apr 3, 2019

Merged

Paket Update #2286

@BlythMeister BlythMeister deleted the BlythMeister:simplify branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.