Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement of fix introduced in PR #3873] Search all the sub-directories under the default packages directory and do not use CompareString while searching under packages directory #3888

Conversation

ruhullahshah
Copy link
Contributor

Problem:

While paket packing if a dependency is not available in the local user nuget cache, before returning the default Nuspec record, we used to seek the package in the default packages directory, but this method is not fool proof as the dependency might be located within a sub-directory of the default pakcages directory, for instance packages\build. Also, on Linux using CompareString causes problems because of case-sensitive file system.

Solution:

Perform an exhaustive search under the default packages directory instead of looking at the top level on and use the plain package name instead of the CompareString

Ruh Ullah Shah and others added 3 commits July 24, 2020 22:40
While paket packing if a dependency is not available in the local user nuget cache, before returning the default Nuspec record, we used to seek the
package in the default packages directory, but this method is not fool proof as the dependency might be located within a sub-directory of the default
pakcages directory.

Solution:
Perform an exhuastive search under the default packages directory instead of looking at the top level only.
problems on Linux because of case sensitive file/directory names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants