Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get version requirements from paket.lock #924

Merged
merged 7 commits into from Jul 21, 2015

Conversation

inosik
Copy link
Contributor

@inosik inosik commented Jul 16, 2015

Addresses #901.

This allows us to get the version requirements from paket.lock instead of paket.dependencies. That means we then require the specific version (version="[x.y.z]"), which is resolved right now. To use this, just issue paket pack [...] lock-dependencies on the command line.

What do you say? Should I add some tests or maybe documentation?

@forki
Copy link
Member

forki commented Jul 19, 2015

could you please create small docs which show (maybe in a table) what version requirement we create for which paket.lock version. Maybe we can switch to the locked versions completely.

@inosik
Copy link
Contributor Author

inosik commented Jul 19, 2015

Maybe we can switch to the locked versions completely.

You mean to always take the constraints from paket.lock? I actually like the default behavior. And it completely makes sense, if the upstream packages follow SemVer, of course.

@forki
Copy link
Member

forki commented Jul 19, 2015

So this should be a per package decision?
On Jul 19, 2015 15:05, "Ilja Nosik" notifications@github.com wrote:

Maybe we can switch to the locked versions completely.

You mean to always take the constraints from paket.lock? I actually like
the default behavior. And it completely makes sense, if the upstream
packages follow SemVer, of course.


Reply to this email directly or view it on GitHub
#924 (comment).

@inosik
Copy link
Contributor Author

inosik commented Jul 19, 2015

I mean we should keep the default behavior, but if one runs paket pack lock-dependencies, all the dependencies of the resulting package(s) should be locked.

I thought you mean to drop the current behavior (taking the constraints from paket.dependencies).

Allow getting the version requirements of dependencies from `paket.lock`
by adding an additional parameter. Also add this parameter all the way
up to `PublicAPI.Pack`.
If we fail to find the requirement for a package, throw an exception
instead of throwing an `KeyNotFoundException`.
Add the parameter to the PackArgs-Type and pass it.
@inosik
Copy link
Contributor Author

inosik commented Jul 20, 2015

I think I'm done here. Maybe somebody could provide a real-world paket.dependencies, paket.lock and paket.references, to show a better example in the docs?

@forki forki merged commit 5f02389 into fsprojects:master Jul 21, 2015
@forki
Copy link
Member

forki commented Jul 21, 2015

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants