-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get version requirements from paket.lock #924
Conversation
|
could you please create small docs which show (maybe in a table) what version requirement we create for which paket.lock version. Maybe we can switch to the locked versions completely. |
d46181a
to
c155efb
Compare
You mean to always take the constraints from |
c155efb
to
5bfb9bd
Compare
|
So this should be a per package decision?
|
|
I mean we should keep the default behavior, but if one runs I thought you mean to drop the current behavior (taking the constraints from |
Allow getting the version requirements of dependencies from `paket.lock` by adding an additional parameter. Also add this parameter all the way up to `PublicAPI.Pack`.
If we fail to find the requirement for a package, throw an exception instead of throwing an `KeyNotFoundException`.
Add the parameter to the PackArgs-Type and pass it.
5bfb9bd
to
ee7a3d3
Compare
|
I think I'm done here. Maybe somebody could provide a real-world |
|
thanks. |
Addresses #901.
This allows us to get the version requirements from
paket.lockinstead ofpaket.dependencies. That means we then require the specific version (version="[x.y.z]"), which is resolved right now. To use this, just issuepaket pack [...] lock-dependencieson the command line.What do you say? Should I add some tests or maybe documentation?