Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective update shows better error message on conflict #980

Merged
merged 1 commit into from Aug 13, 2015

Conversation

mrinaldi
Copy link
Contributor

When I'm updating a single package, the conflict message would not show the other packages requirements that has conflicted.

paket.dependencies:

source https://nuget.org/api/v2

nuget Ninject.Extensions.Interception
nuget Ninject.Extensions.Logging.Log4Net

paket.lock:

NUGET
  remote: https://nuget.org/api/v2
  specs:
    log4net (2.0.3)
    Ninject (2.2.1.4)
    Ninject.Extensions.Interception (2.2.1.2)
      Ninject (>= 2.2.0.0 < 2.3.0.0)
    Ninject.Extensions.Logging (2.2.0.4)
      Ninject (>= 2.2.0.0 < 2.3.0.0)
    Ninject.Extensions.Logging.Log4net (2.2.0.4)
      Ninject.Extensions.Logging (>= 2.2.0.0 < 2.3.0.0)
      log4net (>= 1.0.4)

paket update nuget Ninject.Extensions.Logging.Log4Net version 3.0.1
Outputs:

  Could not resolve package Ninject:
   - Ninject.Extensions.Logging 3.0.1 requested >= 3.0.0.0 < 3.1.0.0

This PR changes to output message to include what other packages have conflicted:

  Could not resolve package Ninject:
   - Ninject.Extensions.Interception 2.2.1.2 requested >= 2.2.0.0 < 2.3.0.0
   - Ninject.Extensions.Logging 3.0.1 requested >= 3.0.0.0 < 3.1.0.0

@forki
Copy link
Member

forki commented Aug 13, 2015

Very cool. Love it

forki added a commit that referenced this pull request Aug 13, 2015
Selective update shows better error message on conflict
@forki forki merged commit 9ecce65 into fsprojects:master Aug 13, 2015
@mrinaldi mrinaldi deleted the improve_conflict_error_message branch August 13, 2015 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants