Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: fix docs generation #337

Merged
merged 2 commits into from Aug 28, 2022
Merged

gha: fix docs generation #337

merged 2 commits into from Aug 28, 2022

Conversation

efiop
Copy link
Member

@efiop efiop commented Aug 28, 2022

ammaraskar/sphinx-action requires docs/requirements.txt that was missing.

GHA now runs on PRs too, just to make sure we don't mess up docs.

ammaraskar/sphinx-action requires docs/requirements.txt that was missing.

GHA now runs on PRs too, just to make sure we don't mess up docs.
@efiop
Copy link
Member Author

efiop commented Aug 28, 2022

Ok, turns out docs generation was completely not operational before 🙁

@efiop
Copy link
Member Author

efiop commented Aug 28, 2022

I hope you folks don't mind me messing with this directly, just want to help improve this project for everyone. 🙏

@efiop efiop added the bug label Aug 28, 2022
@efiop efiop merged commit f9aec5f into fsspec:main Aug 28, 2022
@efiop
Copy link
Member Author

efiop commented Aug 28, 2022

https://fsspec.github.io/adlfs/ works now, but looks like our aim is RTD, similar to gcsfs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant